siddharthteotia commented on a change in pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r546203416
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -515,6 +540,7 @@ public static void
addColumnMetadataInfo(PropertiesConfiguration properties, Str
properties.setProperty(getKeyFor(column, HAS_DICTIONARY),
String.valueOf(hasDictionary));
properties.setProperty(getKeyFor(column, TEXT_INDEX_TYPE),
textIndexType.name());
properties.setProperty(getKeyFor(column, HAS_INVERTED_INDEX),
String.valueOf(hasInvertedIndex));
+ properties.setProperty(getKeyFor(column, HAS_FST_INDEX),
String.valueOf(hasFSTIndex));
Review comment:
This is probably not needed right? In fact, may be should add a new enum
to TEXT_INDEX_TYPE to something like LUCENE_FST. TEXT_INDEX_TYPE is already
serialized in on-disk metadata so just extend it to capture FST
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
