zhangloo333 commented on a change in pull request #6333:
URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556705320
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js
##########
@@ -189,10 +251,10 @@ export default Component.extend({
* @type {Array}
*/
preselectedItems: computed({
- get () {
+ get() {
return [];
},
- set () {
+ set() {
// ignore
}
}),
Review comment:
We can refactor later.
From the codebase, there are no dependent properties on the computed
property. It's not appropriate here. we can be refactored when we migrate the
code to the new codebase.
```
preselectedItems: computed({
get () { get() {
return []; return [];
}, },
set () { set() {
// ignore // ignore
} }
}), }),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
