Jackie-Jiang commented on a change in pull request #6409:
URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557018737
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/H3IndexHandler.java
##########
@@ -86,72 +88,77 @@ public void createH3Indices()
private void createH3IndexForColumn(ColumnMetadata columnMetadata)
throws Exception {
String column = columnMetadata.getColumnName();
- File inProgress = new File(_indexDir, column + ".h3.inprogress");
+ File inProgress = new File(_indexDir, column +
V1Constants.Indexes.H3_INDEX_FILE_EXTENSION + ".inprogress");
File h3IndexFile = new File(_indexDir, column +
V1Constants.Indexes.H3_INDEX_FILE_EXTENSION);
if (!inProgress.exists()) {
// Marker file does not exist, which means last run ended normally.
+
if (_segmentWriter.hasIndexFor(column, ColumnIndexType.H3_INDEX)) {
- // Skip creating range index if already exists.
- LOGGER.info("Found h3 index for segment: {}, column: {}",
_segmentName, column);
+ // Skip creating H3 index if already exists.
+
+ LOGGER.info("Found H3 index for segment: {}, column: {}",
_segmentName, column);
return;
}
// Create a marker file.
FileUtils.touch(inProgress);
} else {
// Marker file exists, which means last run gets interrupted.
- // Remove range index if exists.
+
+ // Remove H3 index if exists.
// For v1 and v2, it's the actual range index. For v3, it's the
temporary range index.
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
