icefury71 commented on a change in pull request #6468:
URL: https://github.com/apache/incubator-pinot/pull/6468#discussion_r561262795
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/SegmentGenerationAndPushTaskGenerator.java
##########
@@ -103,6 +104,21 @@ public String getTaskType() {
return MinionConstants.SegmentGenerationAndPushTask.TASK_TYPE;
}
+ @Override
+ public int getNumConcurrentTasksPerInstance() {
+ String numConcurrentTasksPerInstance = _clusterInfoAccessor
+
.getClusterConfig(MinionConstants.SegmentGenerationAndPushTask.CONFIG_NUMBER_CONCURRENT_TASKS_PER_INSTANCE);
Review comment:
maybe use static import ?
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/SegmentGenerationAndPushTaskGenerator.java
##########
@@ -103,6 +104,21 @@ public String getTaskType() {
return MinionConstants.SegmentGenerationAndPushTask.TASK_TYPE;
}
+ @Override
+ public int getNumConcurrentTasksPerInstance() {
+ String numConcurrentTasksPerInstance = _clusterInfoAccessor
Review comment:
nit: numConcurrentTasksPerInstanceStr
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/ClusterInfoAccessor.java
##########
@@ -157,4 +160,20 @@ public void setRealtimeToOfflineSegmentsTaskMetadata(
public String getVipUrl() {
return _controllerConf.generateVipUrl();
}
+
+ /**
+ * Get the cluster config for a given cluster config.
Review comment:
nit: "For a given config name"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
