fx19880617 commented on pull request #6457: URL: https://github.com/apache/incubator-pinot/pull/6457#issuecomment-764076786
> @fx19880617 > > > In this case, how can we ensure we covered all the references to these getTable methods usage? > > The test failures are caused by not setting all the necessary fields within the `SegmentGeneratorConfig`, which won't happen for the production code. Modified the code to use table name within the table config by default, and also handle the missing table name gracefully. > > > Also how can we unify/distinguish the usage of rawTableName and TableNameWithType.? > > From the interface definition, it should always return the rawTableName, and the caller is expecting rawTableName. Currently it might return tableNameWithType, which IMO is a bug, and the purpose of this PR is to always return the rawTableName. Agreed. So the API user should handle the type conversion if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
