fx19880617 opened a new pull request #6488:
URL: https://github.com/apache/incubator-pinot/pull/6488


   ## Description
   Adding pinot minion metrics to JMX Prometheus reporter.
   
   Publishing metrics:
   Meter:
   ```
   pinot.minion.healthCheckBadCalls
   pinot.minion.healthCheckGoodCalls
   pinot.minion.<task_type>.numberTasksCompleted
   pinot.minion.<task_type>.numberTasksExecuted
   ```
   Timer:
   ```
   pinot.minion.<task_type>.taskExecution
   ```
   
   Sample Screenshot from jconsole
   
![image](https://user-images.githubusercontent.com/1202120/105781810-11fc2580-5f28-11eb-87c5-dd86b9d3413f.png)
   
   Sample output from jmx agent HTTP endpoint:
   ```
   # HELP pinot_minion_healthCheckBadCalls_FifteenMinuteRate Attribute exposed 
for management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckBadCalls"><>FifteenMinuteRate)
   # TYPE pinot_minion_healthCheckBadCalls_FifteenMinuteRate untyped
   pinot_minion_healthCheckBadCalls_FifteenMinuteRate 0.0
   # HELP pinot_minion_healthCheckBadCalls_FiveMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckBadCalls"><>FiveMinuteRate)
   # TYPE pinot_minion_healthCheckBadCalls_FiveMinuteRate untyped
   pinot_minion_healthCheckBadCalls_FiveMinuteRate 0.0
   # HELP pinot_minion_taskExecution_50thPercentile Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>50thPercentile)
   # TYPE pinot_minion_taskExecution_50thPercentile untyped
   
pinot_minion_taskExecution_50thPercentile{id="SegmentGenerationAndPushTask",} 
10880.8888685
   # HELP pinot_minion_healthCheckGoodCalls_OneMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckGoodCalls"><>OneMinuteRate)
   # TYPE pinot_minion_healthCheckGoodCalls_OneMinuteRate untyped
   pinot_minion_healthCheckGoodCalls_OneMinuteRate 0.0
   # HELP pinot_minion_numberTasksExecuted_MeanRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksExecuted"><>MeanRate)
   # TYPE pinot_minion_numberTasksExecuted_MeanRate untyped
   
pinot_minion_numberTasksExecuted_MeanRate{id="SegmentGenerationAndPushTask",} 
0.003897244633574957
   # HELP pinot_minion_taskExecution_999thPercentile Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>999thPercentile)
   # TYPE pinot_minion_taskExecution_999thPercentile untyped
   
pinot_minion_taskExecution_999thPercentile{id="SegmentGenerationAndPushTask",} 
19507.901813
   # HELP pinot_minion_numberTasksExecuted_FifteenMinuteRate Attribute exposed 
for management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksExecuted"><>FifteenMinuteRate)
   # TYPE pinot_minion_numberTasksExecuted_FifteenMinuteRate untyped
   
pinot_minion_numberTasksExecuted_FifteenMinuteRate{id="SegmentGenerationAndPushTask",}
 0.11478700232466675
   # HELP pinot_minion_taskExecution_95thPercentile Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>95thPercentile)
   # TYPE pinot_minion_taskExecution_95thPercentile untyped
   
pinot_minion_taskExecution_95thPercentile{id="SegmentGenerationAndPushTask",} 
19507.901813
   # HELP pinot_minion_taskExecution_FifteenMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>FifteenMinuteRate)
   # TYPE pinot_minion_taskExecution_FifteenMinuteRate untyped
   
pinot_minion_taskExecution_FifteenMinuteRate{id="SegmentGenerationAndPushTask",}
 0.11480210404248671
   # HELP pinot_minion_taskExecution_99thPercentile Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>99thPercentile)
   # TYPE pinot_minion_taskExecution_99thPercentile untyped
   
pinot_minion_taskExecution_99thPercentile{id="SegmentGenerationAndPushTask",} 
19507.901813
   # HELP pinot_minion_numberTasksCompleted_FifteenMinuteRate Attribute exposed 
for management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksCompleted"><>FifteenMinuteRate)
   # TYPE pinot_minion_numberTasksCompleted_FifteenMinuteRate untyped
   
pinot_minion_numberTasksCompleted_FifteenMinuteRate{id="SegmentGenerationAndPushTask",}
 0.11480210404248671
   # HELP pinot_minion_healthCheckGoodCalls_Count Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckGoodCalls"><>Count)
   # TYPE pinot_minion_healthCheckGoodCalls_Count untyped
   pinot_minion_healthCheckGoodCalls_Count 0.0
   # HELP pinot_minion_healthCheckBadCalls_MeanRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckBadCalls"><>MeanRate)
   # TYPE pinot_minion_healthCheckBadCalls_MeanRate untyped
   pinot_minion_healthCheckBadCalls_MeanRate 0.0
   # HELP pinot_minion_taskExecution_Count Attribute exposed for management 
("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>Count)
   # TYPE pinot_minion_taskExecution_Count untyped
   pinot_minion_taskExecution_Count{id="SegmentGenerationAndPushTask",} 2.0
   # HELP pinot_minion_numberTasksExecuted_OneMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksExecuted"><>OneMinuteRate)
   # TYPE pinot_minion_numberTasksExecuted_OneMinuteRate untyped
   
pinot_minion_numberTasksExecuted_OneMinuteRate{id="SegmentGenerationAndPushTask",}
 5.307455576033843E-5
   # HELP pinot_minion_taskExecution_75thPercentile Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>75thPercentile)
   # TYPE pinot_minion_taskExecution_75thPercentile untyped
   
pinot_minion_taskExecution_75thPercentile{id="SegmentGenerationAndPushTask",} 
19507.901813
   # HELP pinot_minion_taskExecution_StdDev Attribute exposed for management 
("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>StdDev)
   # TYPE pinot_minion_taskExecution_StdDev untyped
   pinot_minion_taskExecution_StdDev{id="SegmentGenerationAndPushTask",} 
12200.43870888015
   # HELP pinot_minion_taskExecution_MeanRate Attribute exposed for management 
("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>MeanRate)
   # TYPE pinot_minion_taskExecution_MeanRate untyped
   pinot_minion_taskExecution_MeanRate{id="SegmentGenerationAndPushTask",} 
0.00391800909972824
   # HELP pinot_minion_taskExecution_OneMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>OneMinuteRate)
   # TYPE pinot_minion_taskExecution_OneMinuteRate untyped
   pinot_minion_taskExecution_OneMinuteRate{id="SegmentGenerationAndPushTask",} 
5.657352489676626E-5
   # HELP pinot_minion_numberTasksCompleted_MeanRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksCompleted"><>MeanRate)
   # TYPE pinot_minion_numberTasksCompleted_MeanRate untyped
   
pinot_minion_numberTasksCompleted_MeanRate{id="SegmentGenerationAndPushTask",} 
0.00391652317065401
   100  228k  100  228k    0     0   267k      0 --:--:-- --:--:-- --:--:--  
266k
   # HELP pinot_minion_taskExecution_Max Attribute exposed for management 
("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>Max)
   # TYPE pinot_minion_taskExecution_Max untyped
   pinot_minion_taskExecution_Max{id="SegmentGenerationAndPushTask",} 
19507.901813
   # HELP pinot_minion_healthCheckGoodCalls_MeanRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckGoodCalls"><>MeanRate)
   # TYPE pinot_minion_healthCheckGoodCalls_MeanRate untyped
   pinot_minion_healthCheckGoodCalls_MeanRate 0.0
   # HELP pinot_minion_numberTasksExecuted_Count Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksExecuted"><>Count)
   # TYPE pinot_minion_numberTasksExecuted_Count untyped
   pinot_minion_numberTasksExecuted_Count{id="SegmentGenerationAndPushTask",} 
2.0
   # HELP pinot_minion_numberTasksExecuted_FiveMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksExecuted"><>FiveMinuteRate)
   # TYPE pinot_minion_numberTasksExecuted_FiveMinuteRate untyped
   
pinot_minion_numberTasksExecuted_FiveMinuteRate{id="SegmentGenerationAndPushTask",}
 0.03788835617397894
   # HELP pinot_minion_healthCheckGoodCalls_FifteenMinuteRate Attribute exposed 
for management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckGoodCalls"><>FifteenMinuteRate)
   # TYPE pinot_minion_healthCheckGoodCalls_FifteenMinuteRate untyped
   pinot_minion_healthCheckGoodCalls_FifteenMinuteRate 0.0
   # HELP pinot_minion_numberTasksCompleted_Count Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksCompleted"><>Count)
   # TYPE pinot_minion_numberTasksCompleted_Count untyped
   pinot_minion_numberTasksCompleted_Count{id="SegmentGenerationAndPushTask",} 
2.0
   # HELP pinot_minion_taskExecution_98thPercentile Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>98thPercentile)
   # TYPE pinot_minion_taskExecution_98thPercentile untyped
   
pinot_minion_taskExecution_98thPercentile{id="SegmentGenerationAndPushTask",} 
19507.901813
   # HELP pinot_minion_taskExecution_FiveMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>FiveMinuteRate)
   # TYPE pinot_minion_taskExecution_FiveMinuteRate untyped
   
pinot_minion_taskExecution_FiveMinuteRate{id="SegmentGenerationAndPushTask",} 
0.03793920589491924
   # HELP pinot_minion_numberTasksCompleted_OneMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksCompleted"><>OneMinuteRate)
   # TYPE pinot_minion_numberTasksCompleted_OneMinuteRate untyped
   
pinot_minion_numberTasksCompleted_OneMinuteRate{id="SegmentGenerationAndPushTask",}
 5.657352489676626E-5
   # HELP pinot_minion_taskExecution_Min Attribute exposed for management 
("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>Min)
   # TYPE pinot_minion_taskExecution_Min untyped
   pinot_minion_taskExecution_Min{id="SegmentGenerationAndPushTask",} 
2253.875924
   # HELP pinot_minion_numberTasksCompleted_FiveMinuteRate Attribute exposed 
for management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.numberTasksCompleted"><>FiveMinuteRate)
   # TYPE pinot_minion_numberTasksCompleted_FiveMinuteRate untyped
   
pinot_minion_numberTasksCompleted_FiveMinuteRate{id="SegmentGenerationAndPushTask",}
 0.03793920589491924
   # HELP pinot_minion_taskExecution_Mean Attribute exposed for management 
("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.SegmentGenerationAndPushTask.taskExecution"><>Mean)
   # TYPE pinot_minion_taskExecution_Mean untyped
   pinot_minion_taskExecution_Mean{id="SegmentGenerationAndPushTask",} 
10880.8888685
   # HELP pinot_minion_healthCheckBadCalls_Count Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckBadCalls"><>Count)
   # TYPE pinot_minion_healthCheckBadCalls_Count untyped
   pinot_minion_healthCheckBadCalls_Count 0.0
   # HELP pinot_minion_healthCheckGoodCalls_FiveMinuteRate Attribute exposed 
for management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckGoodCalls"><>FiveMinuteRate)
   # TYPE pinot_minion_healthCheckGoodCalls_FiveMinuteRate untyped
   pinot_minion_healthCheckGoodCalls_FiveMinuteRate 0.0
   # HELP pinot_minion_healthCheckBadCalls_OneMinuteRate Attribute exposed for 
management ("org.apache.pinot.minion.metrics"<type="MinionMetrics", 
name="pinot.minion.healthCheckBadCalls"><>OneMinuteRate)
   # TYPE pinot_minion_healthCheckBadCalls_OneMinuteRate untyped
   pinot_minion_healthCheckBadCalls_OneMinuteRate 0.0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to