kkrugler commented on issue #6491: URL: https://github.com/apache/incubator-pinot/issues/6491#issuecomment-768465903
The [Groovy Template Engine documentation](https://docs.groovy-lang.org/docs/next/html/documentation/template-engines.html#_advanced_usage_note) warns about backslashes in text: > If you happen to be embedding your template directly in your script (as we did above) you have to be careful about backslash escaping. Because the template string itself will be parsed by Groovy before it is passed to the templating framework, you have to escape any backslashes inside GString expressions or scriptlet 'code' that are entered as part of a Groovy program I think an appropriate solution would be to modify `GroovyTemplateUtils.renderTemplate()` to first strip out comment lines (maybe with a boolean parameter to control?) before passing text to the `GROOVY_TEMPLATE_ENGINE`. Or we could try to automatically escape backslashes, but I'd be in favor of removing comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
