jackjlli commented on a change in pull request #6502:
URL: https://github.com/apache/incubator-pinot/pull/6502#discussion_r566600230
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
##########
@@ -158,6 +150,8 @@ private synchronized void
removeAllTasksFromCronExpressions(String tableWithType
if (jobKey.getName().equals(tableWithType)) {
try {
_scheduledExecutorService.deleteJob(jobKey);
+
_controllerMetrics.addMeteredTableValue(getCronJobName(tableWithType,
jobKey.getGroup()),
+ ControllerMeter.CRON_SCHEDULER_JOB_SCHEDULED, -1L);
Review comment:
I feel that `CRON_SCHEDULER_JOB_SCHEDULED` be more of a gauge other than
a meter. E.g., meter is measured on per minute basis. Gauge is like a variable
storing the current value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
