fx19880617 commented on a change in pull request #6525:
URL: https://github.com/apache/incubator-pinot/pull/6525#discussion_r569223477
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -167,11 +167,62 @@ public boolean equals(Object obj) {
}
if (obj instanceof GenericRow) {
GenericRow that = (GenericRow) obj;
- return _fieldToValueMap.equals(that._fieldToValueMap) &&
_nullValueFields.equals(that._nullValueFields);
+ if (!_nullValueFields.containsAll(that._nullValueFields) ||
!that._nullValueFields
+ .containsAll(_nullValueFields)) {
+ return false;
+ }
+ return compareMap(_fieldToValueMap, that._fieldToValueMap);
}
return false;
}
+ private boolean compareMap(Map<String, Object> thisMap, Map<String, Object>
thatMap) {
+ if (thisMap.size() == thatMap.size()) {
Review comment:
yes, cause when I do a deep comparison with nested generic row, there
will be a list of maps containing lists of maps ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
