siddharthteotia commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r572437744
##########
File path: pinot-tools/src/test/resources/memory_estimation/schema.json
##########
@@ -0,0 +1,36 @@
+{
+ "schemaName": "testTable",
+ "dimensionFieldSpecs": [
+ {
Review comment:
Also, if you think about this from integration perspective,
RecommenderDriver doesn't take schema. It takes the schema annotated with
characteristics. (See the files RecommenderDriver, InputManager and
SchemaWithMetadata). So, something to think about for integration. If now you
are providing MemoryEstimator with schema separately then I am not sure if you
are going to change it back to the annotated schema in the follow-up PR when
you will integrate with RecommenderDriver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
