siddharthteotia commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r572456267
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
##########
@@ -107,6 +129,15 @@ public MemoryEstimator(TableConfig tableConfig, File
sampleCompletedSegment, int
_tableDataDir.mkdir();
}
+ public MemoryEstimator(TableConfig tableConfig, File
dataCharacteristicsFile, File schemaFile, int ingestionRate,
+ long maxUsableHostMemory, int tableRetentionHours) {
+ this(tableConfig,
+ generateCompletedSegment(dataCharacteristicsFile, schemaFile,
tableConfig),
Review comment:
Can we add a small test (or ensure manually) that the file location of
the generated completed segment returned by generateCompletedSegment() is in
the same segment file hierarchy as taken by the other constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
