mcvsubbu commented on a change in pull request #6577:
URL: https://github.com/apache/incubator-pinot/pull/6577#discussion_r575612467
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/store/SingleFileIndexDirectory.java
##########
@@ -258,15 +255,15 @@ private void mapBufferEntries()
IndexEntry entry = offsetEntry.getValue();
runningSize += entry.size;
- if (runningSize >= MAX_ALLOCATION_SIZE) {
+ if (runningSize >= MAX_ALLOCATION_SIZE && !offsetAccum.isEmpty()) {
Review comment:
I understand that, but with this check, we will combine the first two
indices together into one larray mmap. May be that is not what we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
