siddharthteotia commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r578063314
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
##########
@@ -107,6 +129,15 @@ public MemoryEstimator(TableConfig tableConfig, File
sampleCompletedSegment, int
_tableDataDir.mkdir();
}
+ public MemoryEstimator(TableConfig tableConfig, File
dataCharacteristicsFile, File schemaFile, int ingestionRate,
+ long maxUsableHostMemory, int tableRetentionHours) {
+ this(tableConfig,
+ generateCompletedSegment(dataCharacteristicsFile, schemaFile,
tableConfig),
Review comment:
Just wanted to ensure that the new code (added in this PR) to generated
the completed segment generates it in the correct directory hierarchy as
expected by the second constructor. Looks like your unit test already covers
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
