mcvsubbu commented on a change in pull request #6590:
URL: https://github.com/apache/incubator-pinot/pull/6590#discussion_r579356325
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
##########
@@ -147,6 +148,9 @@ synchronized void sendRequest(InstanceRequest
instanceRequest)
_channel.writeAndFlush(Unpooled.wrappedBuffer(requestBytes),
_channel.voidPromise());
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.NETTY_CONNECTION_REQUESTS_SENT,
1);
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.NETTY_CONNECTION_BYTES_SENT,
requestBytes.length);
+ String tableName =
instanceRequest.getQuery().getQuerySource().getTableName();
Review comment:
Sorry I misled you here. Not sure why I was thinking this was a server
thing.
You can get the request size by taking the query length in
BaseRequestHandler, but the query response is another thing. Since we respond
with BrokerResponse object, and it is converted to whatever kind of response
(JSON in open source), it is trickier.
Let us discuss
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
