amrishlal commented on a change in pull request #6596:
URL: https://github.com/apache/incubator-pinot/pull/6596#discussion_r580731929



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
##########
@@ -306,6 +306,10 @@ private boolean forceLog(long schedulerWaitMs, long 
numDocsScanned) {
   protected ListenableFuture<byte[]> immediateErrorResponse(ServerQueryRequest 
queryRequest,
       ProcessingException error) {
     DataTable result = new DataTableImplV2();
+
+    Map<String, String> dataTableMetadata = result.getMetadata();

Review comment:
       From what I can tell, using a static DataTable object will lead to race 
conditions because different threads will try to set their own request ids into 
the static DataTable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to