amrishlal commented on a change in pull request #6596:
URL: https://github.com/apache/incubator-pinot/pull/6596#discussion_r581505015
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -438,6 +439,29 @@ public void testBloomFilterTriggering()
}, 600_000L, "Failed to generate bloom filter");
}
+ /** Check if server returns error response quickly without timing out
Broker. */
+ @Test
+ public void testServerErrorWithBrokerTimeout()
Review comment:
QueryRoutingTest (unit) does some of this, but mocks the server away. I
am not seeing a straightforward way of adding an integration test that would
involve both server and broker since the data structures that map broker
request to server response are deep down. Although, I don't think this will be
a problem since all exceptions are now being handled within channelRead0
function.
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -438,6 +439,29 @@ public void testBloomFilterTriggering()
}, 600_000L, "Failed to generate bloom filter");
}
+ /** Check if server returns error response quickly without timing out
Broker. */
+ @Test
+ public void testServerErrorWithBrokerTimeout()
Review comment:
QueryRoutingTest (unit) does some of this, but mocks the server away. I
am not seeing a straightforward way of adding an integration test that would
involve both server and broker since the data structures that map broker
request to server response are deep down. Although, now that all exceptions are
being handled within channelRead0 function, this should not be an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
