amrishlal commented on a change in pull request #6627:
URL: https://github.com/apache/incubator-pinot/pull/6627#discussion_r585788710
##########
File path:
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReaderConfig.java
##########
@@ -32,8 +32,8 @@
private String _header;
private char _delimiter = DEFAULT_DELIMITER;
private char _multiValueDelimiter = DEFAULT_MULTI_VALUE_DELIMITER;
-
private Character _commentMarker; // Default is null
+ private char _escapeCharacter;
Review comment:
Yes, the `\0` is a typo, it should either be `null` (which is the
default in current master) or `\` (since that is the common escape character in
use). From what I see, backward compatibility issues are minimal here, so
setting escape character to `\`, but if there are good reasons to continue with
`null`, we can do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
