jackjlli commented on a change in pull request #6631:
URL: https://github.com/apache/incubator-pinot/pull/6631#discussion_r586019895
##########
File path: pinot-spi/pom.xml
##########
@@ -171,6 +171,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
pinot-avro-base internally depends on pinot-spi. If we don't shade both,
the unshaded jar of pinot-spi would still be pulled. Thus, have to shade two
modules.
```
[INFO] ------------------< org.apache.pinot:pinot-avro-base
>------------------
[INFO] Building Pinot Avro Base 0.7.0-SNAPSHOT
[6/48]
[INFO] --------------------------------[ jar
]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-avro-base
---
[INFO] org.apache.pinot:pinot-avro-base:jar:0.7.0-SNAPSHOT
[INFO] +- org.apache.pinot:pinot-spi:test-jar:tests:0.7.0-SNAPSHOT:test
[INFO] | \- com.fasterxml.jackson.core:jackson-databind:jar:2.10.0:test
[INFO] \- org.apache.pinot:pinot-spi:jar:0.7.0-SNAPSHOT:provided
[INFO] \-
(com.fasterxml.jackson.core:jackson-databind:jar:2.10.0:provided - omitted for
duplicate)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
