amrishlal opened a new pull request #6651: URL: https://github.com/apache/incubator-pinot/pull/6651
## Description JSON data is stored in columns of type STRING, so there is nothing preventing the column from storing bad json string. Bad JSON string in columns will cause json_extract_scalar to throw an exception which would terminate query processing. However, when json_extract_scalar is used within the WHERE clause, we should return the default value instead of throwing exception. This will allow the predicate to be evaluated to either true or false and hence allow the query to complete successfully. Returning default value from json_extract_scalar is an undocumented feature. Ideally, json_extract_scalar should return NULL in when it encounters bad JSON. However, NULL support is currently pending, so this is the best we can do. A good description should include pointers to an issue or design document, etc. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text ## Documentation If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
