siddharthteotia commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r589653733
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/RulesToExecute.java
##########
@@ -134,15 +143,20 @@ public boolean isRecommendBloomFilter() {
return _recommendBloomFilter;
}
+ public boolean isRecommendRealtimeProvisioning() {
+ return _recommendRealtimeProvisioning;
+ }
+
// Be careful with the sequence, each rule can execute individually
// but a rule may depend on its previous rule when they both fired
public enum Rule {
- FlagQueryRule,
+ FlagQueryRule,
KafkaPartitionRule,
InvertedSortedIndexJointRule,
NoDictionaryOnHeapDictionaryJointRule, //
NoDictionaryOnHeapDictionaryJointRule must go after
InvertedSortedIndexJointRule since we do not recommend NoDictionary on cols
with indices
VariedLengthDictionaryRule, // VariedLengthDictionaryRule must go after
NoDictionaryOnHeapDictionaryJointRule since we do not recommend dictionary on
NoDictionary cols
PinotTablePartitionRule, // PinotTablePartitionRule must go after
KafkaPartitionRule to recommend realtime partitions, after
NoDictionaryOnHeapDictionaryJointRule to correctly calculate record size
BloomFilterRule,
+ RealtimeProvisioningRule
Review comment:
Add comments here please explaining the new rule.
What would be better is to move these comments as javadoc for the enum and
describe each rule in a bullet list. Will look much cleaner IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
