chenboat commented on a change in pull request #6653:
URL: https://github.com/apache/incubator-pinot/pull/6653#discussion_r593371836
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
##########
@@ -50,6 +50,8 @@
public static final String INSTANCE_SEGMENT_TAR_DIR = "segmentTarDir";
// Key of segment directory
public static final String INSTANCE_BOOTSTRAP_SEGMENT_DIR =
"bootstrap.segment.dir";
+ // Key of segment store uri
+ public static final String SEGMENT_STORE_URI = "segment.store.uri";
Review comment:
Currently in IndexLoadingConfig, there is also a field called
"segment.store.uri" used by Pinot servers to upload segments to deepstore
during LLC protocol. We do not want to set the deep store uri in two difference
places obviously. I think it is good to put it here. Can you (1) remove the
field in IndexLoadingConfig and (2) make all users to that field to use
InstanceDataManagerConfig's "segment.store.uri" instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
