npawar commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r595585429
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotTableIdealStateBuilder.java
##########
@@ -115,14 +117,22 @@ public static void
buildLowLevelRealtimeIdealStateFor(PinotLLCRealtimeSegmentMan
pinotLLCRealtimeSegmentManager.setUpNewTable(realtimeTableConfig,
idealState);
}
- public static int getPartitionCount(StreamConfig streamConfig) {
- PartitionCountFetcher partitionCountFetcher = new
PartitionCountFetcher(streamConfig);
+ /**
+ * Fetches the list of {@link PartitionGroupInfo} for the stream, with the
help of the current partitionGroups metadata
+ * This call will only skip partitions which have reached end of life and
all messages from that partition have been consumed.
+ * The current partition group metadata is used to determine the offsets
that have been consumed for a partition.
+ * The current partition group metadata is also used to know about existing
partition groupings which should not be disturbed
+ */
+ public static List<PartitionGroupInfo>
getPartitionGroupInfoList(StreamConfig streamConfig,
+ List<PartitionGroupMetadata> currentPartitionGroupMetadataList) {
Review comment:
Added in the method javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
