apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r596214769
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java
##########
@@ -26,6 +26,9 @@
@InterfaceAudience.Public
@InterfaceStability.Stable
public interface AccessControl {
+ String WORKFLOW_NONE = "NONE";
+ String WORKFLOW_BASIC = "BASIC";
+ String WORKFLOW_OAUTH2 = "OAUTH2";
Review comment:
Hardcoding this in an enum would eliminate any extensibility of
`AuthWorkflowInfo` by third parties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
