siddharthteotia commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r599256521
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock)
_operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
0 is not good. LIMIT 0 queries should be rare but we still process the
query on one segment. So, I think we should instrument it and add the actual
value here since this is a special case.
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock)
_operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
0 is not desirable imo. LIMIT 0 queries should be rare but we still
process the query on one segment. So, I think we should instrument it and add
the actual value here since this is a special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
