siddharthteotia commented on a change in pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603648893
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableFactory.java
##########
@@ -31,8 +35,10 @@ public static DataTable getDataTable(ByteBuffer byteBuffer)
throws IOException {
int version = byteBuffer.getInt();
switch (version) {
- case 2:
- return new DataTableImplV2(byteBuffer);
+ case VERSION_2:
+ return convertDataTableImplV2ToV3(new DataTableImplV2(byteBuffer));
Review comment:
Since the implementation between V2 and V3 is decoupled with common
parts abstracted into DataTableUtils, why do we need a converter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
