siddharthteotia commented on a change in pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604408686
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -138,7 +138,7 @@ public DataTable processQuery(ServerQueryRequest
queryRequest, ExecutorService e
String errorMessage = String
.format("Query scheduling took %dms (longer than query timeout of
%dms)", querySchedulingTimeMs,
queryTimeoutMs);
- DataTable dataTable = new DataTableImplV2();
+ DataTable dataTable = new DataTableImplV3();
Review comment:
Discussed this offline with @mqliang. For now we decided to go with
option 1. Add a TODO there to follow-up with a PR which unifies the the way of
constructing empty data table in the same manner everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
