sajjad-moradi opened a new pull request #6731:
URL: https://github.com/apache/incubator-pinot/pull/6731


   ## Description
   With the fix, Rule Engine now works with both `time` and `dateTime` types. 
Previously it used to only work for time column.
   
   ## Testing Done
   - added a unit test for one of the rules to have dateTime column instead of 
time column
   - locally changed the inputs of all the rules in the unit tests to have 
dateTime column instead of time column and they all passed. Didn't want to 
duplicate all the unit tests - one for time column and one for dateTime column 
- so I didn't include them in the PR. One unit test with dateTime column should 
suffice.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to