mayankshriv commented on issue #5829: URL: https://github.com/apache/incubator-pinot/issues/5829#issuecomment-812143648
If we go route1, then we might want to measure overhead with a large response. I have seen orders of magnitude difference in latency seen by the broker vs something on top of the broker (eg query console, python script, etc) which end up doing these kinds of transformations per value. Cheers, Mayank On Thu, Apr 1, 2021 at 11:58 AM Gaurav Joshi ***@***.***> wrote: > I believe there are a couple of ways to tackle this. > > *1.* Given that long precision is lost when UI requests query result and > that the result is display-only (meaning it is not further used in any > business logic or for any processing) the server can simply send all the > data as string values. However, this will require changes in the server as > well as minor changes in the UI. In case the data is required to be used > for some processing, it can be converted into appropriate type using > columnDataTypes - which is when we will run into this issue, again. > (Please correct me in case I am wrong, given some gaps in my Pinot UI > domain knowledge.) > > *2.* We can limit the changes to the UI. One solution I can think of is > using json-bigint or similar library that supports converting large long > values to JavaScript BigInt type and thus retain precision. This will > require disabling native JSON parsing in axios with transformResponse and > use the chosen JSON parsing library instead. > > @shahsank3t <https://github.com/shahsank3t> > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-pinot/issues/5829#issuecomment-812107499>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADAIBTIM62BSEACXL3JIL7TTGS66XANCNFSM4PX3R2MQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
