npawar commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r606528463
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -1243,7 +1259,13 @@ public
LLRealtimeSegmentDataManager(RealtimeSegmentZKMetadata segmentZKMetadata,
// long as the partition function is not changed.
int numPartitions = columnPartitionConfig.getNumPartitions();
try {
- int numStreamPartitions =
_streamMetadataProvider.fetchPartitionCount(/*maxWaitTimeMs=*/5000L);
+ // TODO: currentPartitionGroupMetadata should be fetched from
idealState + segmentZkMetadata, so that we get back accurate partitionGroups
info
+ // However this is not an issue for Kafka, since partitionGroups
never expire and every partitionGroup has a single partition
+ // Fix this before opening support for partitioning in Kinesis
+ int numStreamPartitions = _streamMetadataProvider
Review comment:
Fixed it here. Since I'd already done a PR with the pure renaming. These
2 instances were missed so fixing them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
