mcvsubbu commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r606531151
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -383,7 +383,12 @@
public static class Segment {
public static class Realtime {
public enum Status {
- IN_PROGRESS, DONE
+ // Means the segment is not completed and still consuming stream data
+ IN_PROGRESS,
+ // Means the segment is completed and sealed by some Pinot server and
uploaded
+ DONE,
+ // Means the segment is uploaded to a Pinot controller by an external
party
+ UPLOADED
Review comment:
You should only add enums at the end. But anyways, this is a deeper
change. I was just asking of the other reviewers. Let us revert it and stick to
your PR for now.
@npawar and @Jackie-Jiang may have an opinion. We can discuss separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
