Jackie-Jiang commented on a change in pull request #6754:
URL: https://github.com/apache/incubator-pinot/pull/6754#discussion_r609131209
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
##########
@@ -104,6 +105,8 @@ public void process()
defaultColumnHandler.updateDefaultColumns();
_segmentMetadata = new SegmentMetadataImpl(_indexDir);
_segmentDirectory.reloadMetadata();
+ } else {
+ LOGGER.warn("The table schema is null for the segment {}.",
_segmentMetadata.getName());
Review comment:
```suggestion
LOGGER.warn("Skip creating default columns for segment: {} without
schema", _segmentMetadata.getName());
```
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
##########
@@ -81,6 +81,7 @@ public SegmentPreProcessor(File indexDir, IndexLoadingConfig
indexLoadingConfig,
public void process()
throws Exception {
if (_segmentMetadata.getTotalDocs() == 0) {
+ LOGGER.info("Skip preprocessing because the segment {} has 0 doc.",
_segmentMetadata.getName());
Review comment:
```suggestion
LOGGER.info("Skip preprocessing empty segment: {}",
_segmentMetadata.getName());
```
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -133,6 +133,7 @@ public void updateDefaultColumns()
// Compute the action needed for each column.
Map<String, DefaultColumnAction> defaultColumnActionMap =
computeDefaultColumnActionMap();
if (defaultColumnActionMap.isEmpty()) {
+ LOGGER.info("No default column action needed for the segment {}.",
_segmentMetadata.getName());
Review comment:
I would avoid logging this because it will be logged in 99% of the case,
where no default columns need to be generated. We already have logs if we do
need to generate default columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
