sajjad-moradi commented on pull request #6789: URL: https://github.com/apache/incubator-pinot/pull/6789#issuecomment-822667740
A few points about the updates on the PR: 1) I had to recursively go over the expression tree in each SUM function to find if the columns used in different branches of the expression tree are all metrics. 2) There was an invalid function name in the integration test (instead of SUM, I'd put SOME!!), but the test was passing because inputManager swallows invalid sql strings. I fixed the issues and made sure that new sql strings are valid and the rule gets executed properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
