mikecdavis-dd opened a new pull request #6816:
URL: https://github.com/apache/incubator-pinot/pull/6816
## Description
This PR adds the ability to inject environment variables to the respective
containers. Variables can either be added from existing secrets or configMaps
through `envFrom` or they can be added individually through an `extraEnv`.
Example:
```yaml
server:
envFrom:
- secretRef:
name: my-secret
extraEnv:
- name: PINOT_CUSTOM_ENV_1
value: my-value-1
- name: PINOT_CUSTOM_ENV_2
value: my-value-2
```
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [x] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
Adds support to inject environment variables via the Pinot helm chart.
Variables can either be added from existing secrets or configMaps through
`envFrom` or they can be added individually through the `extraEnv` array.
## Documentation
To inject custom environment variables you can use the `envFrom` or
`extraEnv` properties within `values.yaml` within the respective containers.
* Use `envFrom` to define all of the ConfigMap or Secret data as container
environment variables.
* Use `extraEnv` to add individual key value pairs as container environment
variables.
Example:
```yaml
server:
envFrom:
- secretRef:
name: my-secret
extraEnv:
- name: PINOT_CUSTOM_ENV_1
value: my-value-1
- name: PINOT_CUSTOM_ENV_2
value: my-value-2
```
See the kubernetes doc on [Define Environment Variables for a
Container](https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/)
for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
