jackjlli commented on a change in pull request #6840:
URL: https://github.com/apache/incubator-pinot/pull/6840#discussion_r620490715
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
##########
@@ -165,9 +146,13 @@ public SuccessResponse addTable(String tableConfigStr,
@Context HttpHeaders http
throw new ControllerApplicationException(LOGGER, e.getMessage(),
Response.Status.BAD_REQUEST, e);
}
try {
- ensureMinReplicas(tableConfig);
- ensureStorageQuotaConstraints(tableConfig);
- verifyTableConfigs(tableConfig);
+ try {
+ TableConfigUtils.ensureMinReplicas(tableConfig,
_controllerConf.getDefaultTableMinReplicas());
+ TableConfigUtils.ensureStorageQuotaConstraints(tableConfig,
_controllerConf.getDimTableMaxSize());
+
checkHybridTableConfig(TableNameBuilder.extractRawTableName(tableName),
tableConfig);
+ } catch (Exception e) {
+ throw new PinotHelixResourceManager.InvalidTableConfigException(e);
Review comment:
Should we consider taking `InvalidTableConfigException` out of
`PinotHelixResourceManager`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
