mayankshriv commented on a change in pull request #6855:
URL: https://github.com/apache/incubator-pinot/pull/6855#discussion_r621738846
##########
File path:
pinot-common/src/main/java/org/apache/pinot/parsers/QueryCompiler.java
##########
@@ -24,6 +24,10 @@
/**
* Interface for Pinot Query compilers.
*/
-public interface AbstractCompiler {
- BrokerRequest compileToBrokerRequest(String expression);
+public interface QueryCompiler {
Review comment:
Although I don't think this is a public interface or should create any
backward incompatibility (don't expect folks have their own implementations),
but still wanted to call this out here.
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -71,7 +80,8 @@
// Basic input fields
public Long _qps = DEFAULT_QPS;
- public Long _numMessagesPerSecInKafkaTopic =
DEFAULT_NUM_MESSAGES_PER_SEC_IN_KAFKA_TOPIC; // messages per sec for kafka to
consume
+ public Long _numMessagesPerSecInKafkaTopic =
DEFAULT_NUM_MESSAGES_PER_SEC_IN_KAFKA_TOPIC;
+ // messages per sec for kafka to consume
Review comment:
Indentation is off, or is the github UI showing it as off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
