Jackie-Jiang commented on a change in pull request #6867:
URL: https://github.com/apache/incubator-pinot/pull/6867#discussion_r623666777
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java
##########
@@ -272,6 +272,9 @@ private void handlePostCreation()
// Write the index files to disk
indexCreator.setSegmentName(segmentName);
indexCreator.seal();
+ } catch (Exception e) {
+ LOGGER.error("Failed to seal indexCreator", e);
Review comment:
Ideally we should either log error or throw the exception, or we might
log the same exception twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
