amrishlal commented on a change in pull request #6878:
URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r627776375
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/EqualsPredicateEvaluatorFactory.java
##########
@@ -72,6 +72,7 @@ public static BaseRawValueBasedPredicateEvaluator
newRawValueBasedEvaluator(EqPr
case TIMESTAMP:
return new
LongRawValueBasedEqPredicateEvaluator(TimestampUtils.toMillisSinceEpoch(value));
case STRING:
+ case JSON:
Review comment:
Reverting all PredicateEvaluator changes. We may need to support EQUALS
and NOT_EQUALS, but it doesn't need to be done with this PR.
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java
##########
@@ -87,7 +89,15 @@
@Override
public void add(String jsonString)
throws IOException {
-
addFlattenedRecords(JsonUtils.flatten(JsonUtils.stringToJsonNode(jsonString)));
+ JsonNode jsonNode = JsonUtils.stringToJsonNode(jsonString);
Review comment:
Fixed.
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -633,6 +633,7 @@ public static void
addColumnMetadataInfo(PropertiesConfiguration properties, Str
properties.setProperty(getKeyFor(column, TOTAL_DOCS),
String.valueOf(totalDocs));
DataType dataType = fieldSpec.getDataType();
properties.setProperty(getKeyFor(column, DATA_TYPE),
String.valueOf(dataType));
+ properties.setProperty(getKeyFor(column, STORAGE_FORMAT),
V1Constants.Str.STORAGE_FORMAT_DEFAULT_VALUE);
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
