This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch compare-state-ignore-cases in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 4171d56a171f4a4f887e01afc59d550ad86858e7 Author: Jack Li(Analytics Engineering) <[email protected]> AuthorDate: Thu May 13 16:07:24 2021 -0700 Compare state of rate limiting with ignoring cases --- .../controller/api/resources/PinotBrokerRestletResource.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotBrokerRestletResource.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotBrokerRestletResource.java index 5395e9c..fe436b1 100644 --- a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotBrokerRestletResource.java +++ b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotBrokerRestletResource.java @@ -221,21 +221,22 @@ public class PinotBrokerRestletResource { throw new ControllerApplicationException(LOGGER, String.format("'%s' is not a valid broker instance name.", brokerInstanceName), Response.Status.BAD_REQUEST); } - validateQueryQuotaStateChange(state); + String stateInUpperCases = state.toUpperCase(); + validateQueryQuotaStateChange(stateInUpperCases); List<String> liveInstances = _pinotHelixResourceManager.getOnlineInstanceList(); if (!liveInstances.contains(brokerInstanceName)) { throw new ControllerApplicationException(LOGGER, String.format("Instance '%s' not found.", brokerInstanceName), Response.Status.NOT_FOUND); } - _pinotHelixResourceManager.toggleQueryQuotaStateForBroker(brokerInstanceName, state); + _pinotHelixResourceManager.toggleQueryQuotaStateForBroker(brokerInstanceName, stateInUpperCases); String msg = - String.format("Set query rate limiting to: %s for all tables in broker: %s", state, brokerInstanceName); + String.format("Set query rate limiting to: %s for all tables in broker: %s", stateInUpperCases, brokerInstanceName); LOGGER.info(msg); return new SuccessResponse(msg); } private void validateQueryQuotaStateChange(String state) { - if (!"ENABLE".equalsIgnoreCase(state) && !"DISABLE".equalsIgnoreCase(state)) { + if (!"ENABLE".equals(state) && !"DISABLE".equals(state)) { throw new ControllerApplicationException(LOGGER, "Invalid query quota state: " + state, Response.Status.BAD_REQUEST); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
