deemoliu commented on a change in pull request #6924:
URL: https://github.com/apache/incubator-pinot/pull/6924#discussion_r633956334
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java
##########
@@ -171,7 +172,15 @@ public ValidDocIndexReader getValidDocIndex() {
@Override
public GenericRow getRecord(int docId, GenericRow reuse) {
// NOTE: Use PinotSegmentRecordReader to read immutable segment
- throw new UnsupportedOperationException();
+ try {
+ PinotSegmentRecordReader pinotSegmentRecordReader = new
PinotSegmentRecordReader();
Review comment:
gotcha, thanks @Jackie-Jiang for review. Do you think i should init
record reader for all immutableSegment, or should i only initialize when
immutableSegment enabledUpsert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
