jackjlli commented on a change in pull request #6936:
URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r635619654
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerQueryPhase.java
##########
@@ -30,6 +30,8 @@
QUERY_EXECUTION,
QUERY_ROUTING,
SCATTER_GATHER,
+ SERVER_PROCESSING,
Review comment:
We couldn't avoid gc from happening. Wherever the gc happens is the
place we should account for the time. I've just refactored the code in the
latest push, which makes it more clear. Basically the scatter & gather consists
of 3 parts:
* request sent from broker to server
* query being processed (totalQueryTime)
* response sent from server to broker
If gc happens on any of the steps above, it should be measured in just that
step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
