siddharthteotia commented on a change in pull request #6946:
URL: https://github.com/apache/incubator-pinot/pull/6946#discussion_r635685922
##########
File path:
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java
##########
@@ -134,18 +136,19 @@ public static Schema getPinotSchemaFromAvroDataFile(File
avroDataFile)
* @param complexType if allows complex-type handling
* @param unnestFields the fields to unnest
* @param delimiter the delimiter separating components in nested structure
+ * @param collectionToJsonMode to mode of converting collection to JSON
string
* @return Pinot schema
*/
public static Schema getPinotSchemaFromAvroSchemaFile(File avroSchemaFile,
@Nullable Map<String, FieldSpec.FieldType> fieldTypeMap, @Nullable
TimeUnit timeUnit, boolean complexType,
- List<String> unnestFields, String delimiter)
+ List<String> unnestFields, String delimiter,
ComplexTypeConfig.CollectionToJsonMode collectionToJsonMode)
Review comment:
For (1), you might want to change the name to `fieldsToUnnest`. I see
the admin command has unnestFields as well. I missed it earlier.
For (2), I prefer the verbose name. `collectionToJsonMode` doesn't really
imply that this is for collections not unnested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
