sajjad-moradi commented on a change in pull request #6976:
URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639324094
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -292,12 +292,12 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
tableNameWithType);
zkDownloadUri = downloadUri;
} else {
- zkDownloadUri = getZkDownloadURIForSegmentUpload(tableNameWithType,
segmentName);
+ zkDownloadUri = getZkDownloadURIForSegmentUpload(tableName,
segmentName);
}
// Zk operations
- completeZkOperations(enableParallelPushProtection, headers,
finalSegmentFile, tableNameWithType, segmentMetadata,
- segmentName, zkDownloadUri, moveSegmentToFinalLocation,
crypterClassName);
+ completeZkOperations(enableParallelPushProtection, headers,
finalSegmentFile, tableName, tableNameWithType,
Review comment:
I originally had it like that and derived rawTableName by invoking
`TableNameBuilder.extractRawTableName()`. But `completedZkOperations()` is a
private method that's being used only once. We already have rawTableName in
the caller, so we can pass it there as well to prevent another function call to
extract the raw table name.
If you still think it looks better to pass only tableNameWithType, I can
simply change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
