snleee commented on a change in pull request #6975:
URL: https://github.com/apache/incubator-pinot/pull/6975#discussion_r644371094
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java
##########
@@ -64,6 +70,12 @@
File workingDir)
throws Exception;
+ /**
+ * Returns the segment ZK metadata custom map modifier.
+ */
+ protected abstract SegmentZKMetadataCustomMapModifier
getSegmentZKMetadataCustomMapModifier(
Review comment:
Can we move this to `BaseTaskExecutor`?
We have the same abstract function defined in
`BaseSingleSegmentConversionExecutor`. After we move this to
`BaseTaskExecutor`, we can remove this from both
`BaseSingleSegmentConversionExecutor` and
`BaseMultipleSegmentsConversionExecutor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
