desaijay230592 opened a new pull request #7019:
URL: https://github.com/apache/incubator-pinot/pull/7019
… map field and rename timeout variables to follow timeunit convention
## Description
There was a bug in the HelixServerStarter code which would prevent us to
update zookeeper node's mapFields with correct environment properties.
Secondly, changed the AzureEnvironmentProvider variable names to include time
units as suffix for better readability and debuggability.
Previous Wrong Syntax:
```
Map<String, String> existingEnvironmentConfigsMap =
instanceConfig.getRecord().getMapField(
CommonConstants.ENVIRONMENT_IDENTIFIER);
if (existingEnvironmentConfigsMap != null &&
!existingEnvironmentConfigsMap.equals(environmentProperties)) {
do Something......
}
```
The above check would prevent us to add values to mapFields for environment
key if it not already present.
Corrected Syntax:
```
Map<String, String> existingEnvironmentConfigsMap =
instanceConfig.getRecord().getMapField(
CommonConstants.ENVIRONMENT_IDENTIFIER);
if (existingEnvironmentConfigsMap == null ||
!existingEnvironmentConfigsMap.equals(environmentProperties)) {
do Something......
}
```
The corrected check will resolve the bug shown in the faulty syntax and will
update mapFields for environment key when it is not present in the map as well
as when the value set has a mismatch.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
