xiangfu0 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r644320872
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -217,65 +217,11 @@ public boolean equals(Object obj) {
}
if (obj instanceof GenericRow) {
GenericRow that = (GenericRow) obj;
- if (!_nullValueFields.containsAll(that._nullValueFields) ||
!that._nullValueFields
Review comment:
make sense
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -217,65 +217,11 @@ public boolean equals(Object obj) {
}
if (obj instanceof GenericRow) {
GenericRow that = (GenericRow) obj;
- if (!_nullValueFields.containsAll(that._nullValueFields) ||
!that._nullValueFields
Review comment:
I think the issue was there could be a deep comparison for nested
structure.
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -217,65 +217,11 @@ public boolean equals(Object obj) {
}
if (obj instanceof GenericRow) {
GenericRow that = (GenericRow) obj;
- if (!_nullValueFields.containsAll(that._nullValueFields) ||
!that._nullValueFields
Review comment:
I think you should be good if the test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
