GSharayu commented on a change in pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648716954
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -237,11 +237,16 @@ private void reorderDimsAndBuildMap()
_colNameToIntMap = new HashMap<>();
_dimNamesInvertedSortedIndexApplicable = new HashSet<>(_dimNames);
+ _dimNamesInvertedSortedIndexApplicable.addAll(_metricNames);
+ _dimNamesInvertedSortedIndexApplicable.addAll(_dateTimeNames);
+
_dimNamesInvertedSortedIndexApplicable.remove(sortedColumn);
_dimNamesInvertedSortedIndexApplicable.removeAll(invertedIndexColumns);
_dimNamesInvertedSortedIndexApplicable.removeAll(noDictionaryColumns);
HashSet<String> dimNamesInveredSortedIndexNotApplicable = new
HashSet<>(_dimNames);
+ dimNamesInveredSortedIndexNotApplicable.addAll(_metricNames);
Review comment:
updated! This change will also update the Atomic number value in test
case for QueryInvertedSortedIndexRecommender.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
