GSharayu commented on a change in pull request #7047:
URL: https://github.com/apache/incubator-pinot/pull/7047#discussion_r649632684
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/RequestStatistics.java
##########
@@ -220,6 +222,10 @@ public long getOfflineThreadCpuTimeNs() {
return _offlineThreadCpuTimeNs;
}
+ public int getNumRowsResultSet() { return _numRowsResultSet; }
+
+ public void setNumRowsResultSet(int numRowsResultSet) { _numRowsResultSet =
numRowsResultSet; }
Review comment:
Most of the getters and setters are used here, should we add a follow up
to clean them as well
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/RequestStatistics.java
##########
@@ -220,6 +222,10 @@ public long getOfflineThreadCpuTimeNs() {
return _offlineThreadCpuTimeNs;
}
+ public int getNumRowsResultSet() { return _numRowsResultSet; }
+
+ public void setNumRowsResultSet(int numRowsResultSet) { _numRowsResultSet =
numRowsResultSet; }
Review comment:
Most of the getters and setters are unused here, should we add a follow
up to clean them as well
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##########
@@ -232,6 +232,7 @@ public BrokerResponseNative reduceOnDataTable(BrokerRequest
brokerRequest,
}
// Set execution statistics.
+ ResultTable resultTable = brokerResponseNative.getResultTable();
Review comment:
updated!
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/RequestStatistics.java
##########
@@ -220,6 +222,10 @@ public long getOfflineThreadCpuTimeNs() {
return _offlineThreadCpuTimeNs;
}
+ public int getNumRowsResultSet() { return _numRowsResultSet; }
+
+ public void setNumRowsResultSet(int numRowsResultSet) { _numRowsResultSet =
numRowsResultSet; }
Review comment:
updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
