Jackie-Jiang commented on a change in pull request #7089:
URL: https://github.com/apache/incubator-pinot/pull/7089#discussion_r659028715
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -66,6 +66,10 @@
public static final String CONTROLLER_MODE = "controller.mode";
public static final String LEAD_CONTROLLER_RESOURCE_REBALANCE_STRATEGY =
"controller.resource.rebalance.strategy";
+ // Comma separated list of list of packages that contain TableConfigTuners
to be added to the registry
+ public static final String TABLE_CONFIG_TUNER_PACKAGES =
"controller.table.config.tuner.packages";
+ public static final String DEFAULT_TABLE_CONFIG_TUNER_PACKAGES =
TableConfigTunerRegistry.class.getPackage().getName();
Review comment:
This is `org.apache.pinot.common.config.tunner`, which is not the same
as the current package `org.apache.pinot`
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTunerRegistry.java
##########
@@ -67,11 +90,15 @@ private TableConfigTunerRegistry() {
}
}
});
- LOGGER.info("Initialized TableConfigTunerRegistry with {} tuners: {}",
_configTunerMap.size(),
- _configTunerMap.keySet());
+
+ _init = true;
+ LOGGER.info("Initialized TableConfigTunerRegistry with {} tuners: {} in {}
ms", _configTunerMap.size(),
+ _configTunerMap.keySet(), (System.currentTimeMillis() - startTime));
}
public static TableConfigTuner getTuner(String name) {
+ TableConfigTunerRegistry.init(Arrays.asList("org.apache.pinot"));
Review comment:
Remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
