jackjlli commented on a change in pull request #7091:
URL: https://github.com/apache/incubator-pinot/pull/7091#discussion_r659362999
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SimpleMinionClusterIntegrationTest.java
##########
@@ -85,18 +85,34 @@ public void setUp()
startMinion();
}
+ private void verifyTaskCount(String task, int errors, int waiting, int
running, int total) {
+ PinotHelixTaskResourceManager.TaskCount taskCount =
_helixTaskResourceManager.getTaskCount(task);
+ assertEquals(taskCount.getError(), errors);
+ assertEquals(taskCount.getWaiting(), waiting);
+ assertEquals(taskCount.getRunning(), running);
+ assertEquals(taskCount.getTotal(), total);
+ }
+
@Test
public void testStopResumeDeleteTaskQueue() {
// Hold the task
HOLD.set(true);
+
assertEquals(_helixTaskResourceManager.getTasksInProgress(TASK_TYPE).size(),0);
+ verifyTaskCount("Task_" + TASK_TYPE + "_1624403781879", 0, 0, 0, 0);
// Should create the task queues and generate a task
- assertNotNull(_taskManager.scheduleTasks().get(TASK_TYPE));
+ String task1 = _taskManager.scheduleTasks().get(TASK_TYPE);
+ assertNotNull(task1);
assertTrue(_helixTaskResourceManager.getTaskQueues()
.contains(PinotHelixTaskResourceManager.getHelixJobQueueName(TASK_TYPE)));
+
assertTrue(_helixTaskResourceManager.getTasksInProgress(TASK_TYPE).contains(task1));
+ verifyTaskCount(task1, 0, 1, 1, 2);
// Should generate one more task
- assertNotNull(_taskManager.scheduleTask(TASK_TYPE));
+ String task2 = _taskManager.scheduleTask(TASK_TYPE);
+ assertNotNull(task2);
+
assertTrue(_helixTaskResourceManager.getTasksInProgress(TASK_TYPE).contains(task2));
+ verifyTaskCount(task2, 0, 2, 0, 2);
Review comment:
Why does the total number of task remain unchanged even after scheduling
one more task?
Could we have some comment on why the number of running tasks becomes 0 from
1 after scheduling one more task here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
