mayankshriv commented on a change in pull request #7101:
URL: https://github.com/apache/incubator-pinot/pull/7101#discussion_r660788933
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##########
@@ -27,11 +29,18 @@
* Interface for Table Config Tuner.
*/
public interface TableConfigTuner {
+ /**
+ *
+ */
/**
* Used to initialize underlying implementation with Schema
* and custom properties (eg: metrics end point)
+ *
+ * @param pinotHelixResourceManager Pinot Helix Resource Manager to access
Helix resources
+ * @param tunerConfig Tuner configurations
+ * @param schema Table schema
*/
- void init(TunerConfig props, Schema schema);
+ void init(@Nullable PinotHelixResourceManager pinotHelixResourceManager,
TunerConfig tunerConfig, Schema schema);
Review comment:
The existing `RealtimeAutoIndexTuner` implementation is very simplistic
and does not even have access to resource manager. Will add annotation to the
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
